Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin to maven publish #28

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Conversation

buildbreaker
Copy link
Contributor

@buildbreaker buildbreaker commented Mar 14, 2023

Adding the generator plugin to maven publish.

Gradle seems to rename the artifact locally so we'll just reference that forced name

@pkwarren
Copy link
Contributor

Verified make releaselocal works to install the plugin to the local Maven repository, however looks like both ci and ci/crosstests are failing.

@buildbreaker buildbreaker requested a review from rebello95 March 14, 2023 14:54
)
}

// Workaround for overriding the published library name to "connect-kotlin-okhttp".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated?

@buildbreaker
Copy link
Contributor Author

Yeah. The tests are failing because Gradle is outputting a different named artifact with this set up. I ended up fixing up the references.

@buildbreaker buildbreaker merged commit 6d09156 into main Mar 14, 2023
@buildbreaker buildbreaker deleted the achiu/add-plugin-to-maven-publish branch March 14, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants