Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to conformance suite v1.0.1 #253

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Update to conformance suite v1.0.1 #253

merged 1 commit into from
Apr 5, 2024

Conversation

jhump
Copy link
Member

@jhump jhump commented Apr 5, 2024

This includes a few minor fixes, too:

  1. For Connect unary RPCs, the error metadata included only headers, but should include both headers and trailers.
  2. For gRPC and gRPC-Web protocols, when a "trailers-only" response is received (where there are only HTTP headers and no body or other trailers, and the headers are to be interpreted as trailers), report those headers as trailers.

@jhump jhump changed the title Updates to conformance suite v1.0.1 Update to conformance suite v1.0.1 Apr 5, 2024
@jhump jhump requested a review from pkwarren April 5, 2024 20:41
@jhump jhump merged commit bcf420f into main Apr 5, 2024
8 of 9 checks passed
@jhump jhump deleted the jh/conformance-v1.0.1 branch April 5, 2024 21:20
pkwarren pushed a commit that referenced this pull request Apr 19, 2024
This includes a few minor fixes, too:
1. For Connect unary RPCs, the error metadata included only headers, but
should include both headers and trailers.
2. For gRPC and gRPC-Web protocols, when a "trailers-only" response is
received (where there are only HTTP headers and no body or other
trailers, and the headers are to be interpreted as trailers), report
those headers as trailers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants