Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release/close as final release step #25

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fix release/close as final release step #25

merged 2 commits into from
Mar 13, 2023

Conversation

buildbreaker
Copy link
Contributor

@buildbreaker buildbreaker commented Mar 13, 2023 •
edited
Loading

The current release flow is the following:

  1. Build the connect-kotlin runtime libraries
  2. Generate asc files for each binary to upload
  3. Upload all artifacts to sonatype release.
  4. Release the uploaded artifacts and close the sonatype repository
  5. Upload plugin binaries to Github releases

The main issue here is that when 4 fails, it will skip the remaining release steps.

Additionally, if any of the steps after 4 fails, a retry will not work as Sonatype will fail step 4 on a retry.

The change here is to instead handle the close repository step last

@buildbreaker buildbreaker requested a review from rebello95 March 13, 2023 15:17
@buildbreaker buildbreaker merged commit 8986b33 into main Mar 13, 2023
@buildbreaker buildbreaker deleted the achiu/fix-release-close-as-final-release-step branch March 13, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotmjackson elliotmjackson elliotmjackson approved these changes

@rebello95 rebello95 Awaiting requested review from rebello95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buildbreaker @elliotmjackson