Update send() to forward all errors (#22)

connectrpc · Mar 9, 2023 · 69c77b6 · 69c77b6
1 parent b2f5e55
commit 69c77b6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/library/src/main/kotlin/build/buf/connect/http/HTTPClientInterface.kt b/library/src/main/kotlin/build/buf/connect/http/HTTPClientInterface.kt
@@ -56,8 +56,12 @@ class Stream(
         if (isClosed()) {
             return Result.failure(IllegalStateException("cannot send. underlying stream is closed"))
         }
-        onSend(buffer)
-        return Result.success(Unit)
+        return try {
+            onSend(buffer)
+            Result.success(Unit)
+        } catch (e: Throwable) {
+            Result.failure(e)
+        }
     }
 
     fun close() {

diff --git a/okhttp/src/main/kotlin/build/buf/connect/okhttp/OkHttpStream.kt b/okhttp/src/main/kotlin/build/buf/connect/okhttp/OkHttpStream.kt
@@ -193,7 +193,7 @@ internal class PipeDuplexRequestBody(
                 bufferedSink.writeAll(buffer)
                 bufferedSink.flush()
             }
-        } catch (e: Throwable) {
+        } finally {
             close()
         }
     }