Enable protoc-gen-connect-go usage with editions #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchadwick-buf
force-pushed
the
feature/editions
branch
from
5dc95ba to
d3cb04d
Compare
akshayjshah
approved these changes
Jun 24, 2024
jchadwick-buf
force-pushed
the
feature/editions
branch
from
d3cb04d to
8009712
Compare
Signed-off-by: John Chadwick <[email protected]>
jchadwick-buf
force-pushed
the
feature/editions
branch
from
8009712 to
381e5d4
Compare
akshayjshah
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect Go and its code generator are agnostic to editions as far as I have been able to tell. I have tried using Connect Go with different sets of editions features, and all is working well so far. So, this PR simply enables it and sets the current range of supported editions to all of the currently-valid editions values (proto2 through 2023.)