Upgrade to go1.22 and min version go1.20 #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
reviewed
Feb 16, 2024
emcfarlane
commented
Feb 16, 2024
| @@ -9,8 +9,8 @@ retract ( | |||
|
|
|||
| require ( | |||
| github.com/google/go-cmp v0.5.9 | |||
| golang.org/x/net v0.17.0 | |||
| golang.org/x/net v0.21.0 | |||
There was a problem hiding this comment.
Related to release: golang/net@c630100
akshayjshah
reviewed
Feb 16, 2024
akshayjshah
requested changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the go version to 1.22 and the min version to go1.20. This was prompted by this CI failure: https://github.com/connectrpc/connect-go/actions/runs/7932731168/job/21659863630 which I believe is related to this issue: golang/go#55846.
Also included is a removal of a workaround for 1.19 header handling introduced here: #406