Set X-User-Agent in gRPC-Web clients #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gRPC-Web pseudo-specification isn't totally clear, but it sounds like it requires setting `X-User-Agent` instead of `User-Agent` as a part of the protocol. This makes sense in browsers, where JS _can't_ set `User-Agent`, but it's very odd for backend clients. This PR proposes splitting the difference and setting both headers.
timostamm
approved these changes
Aug 25, 2023
bufdev
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC-Web pseudo-specification isn't totally clear, but it sounds
like it requires setting
X-User-Agentinstead ofUser-Agentas apart of the protocol. This makes sense in browsers, where JS can't set
User-Agent, but it's very odd for backend clients. This PR proposessplitting the difference and setting both headers.