Include Go 1.21.0 in CI #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this release, we're following AWS's lead and committing to support for the last _three_ Go releases.
Make the Makefile a bit less repetitive.
akshayjshah
commented
Aug 16, 2023
| @@ -7,6 +7,8 @@ MAKEFLAGS += --warn-undefined-variables | |||
| MAKEFLAGS += --no-builtin-rules | |||
| MAKEFLAGS += --no-print-directory | |||
| BIN := .tmp/bin | |||
| export PATH := $(BIN):$(PATH) | |||
| export GOBIN := $(abspath $(BIN)) | |||
There was a problem hiding this comment.
In a subsequent PR, I'm planning to rip out our homegrown support for overriding the Go compiler in use. Now that 1.21 is out, users can set GOTOOLCHAIN without any special magic in this Makefile.
bufdev
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Go 1.21.0 in CI, and update
golangci-lintto a version that supportsthe new runtime.
As part of this change, we're committing to support for the last 3 versions of
Go. This ends up including a version of Go that no longer receives security
patches, but it matches AWS and some large companies' very slow upgrade cycles.