Drain stream and error on trailing data #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
commented
Jun 28, 2023
emcfarlane
force-pushed
the
emcfarlane/drain-eof
branch
from
df2f8da to
b73bc7f
Compare
jchadwick-buf
approved these changes
Jun 28, 2023
|
Block on https://github.com/bufbuild/connect-go/pull/539 need to expand these testcases for grpc and grpc-web. |
akshayjshah
reviewed
Jun 29, 2023
akshayjshah
approved these changes
Jul 11, 2023
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
For connect and gRPC-web on receiving end of stream payloads ensure no extra data is written by draining the reader and erroring on more data. Extension of https://github.com/bufbuild/connect-go/pull/533 Fixes https://github.com/bufbuild/connect-go/issues/427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For connect and gRPC-web on receiving end of stream payloads ensure no extra data is written by draining the reader and erroring on more data.
Extension of #533
Fixes #427