Simplify code when pooled buffers aren't returned #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some error handling cases, we're retrieving a value from the sync.Pool and explicitly not returning it. Instead, we might simplify things and just allocate a buffer (since we already know the size) and use it and not put extra work on the pool to garbage collect objects that are retrieved but never returned.
pkwarren
commented
Jun 26, 2023
| @@ -171,15 +171,12 @@ func (r *envelopeReader) Unmarshal(message any) *Error { | |||
| // stream. Save the message for protocol-specific code to process and | |||
| // return a sentinel error. Since we've deferred functions to return env's | |||
| // underlying buffer to a pool, we need to keep a copy. | |||
| copiedData := make([]byte, data.Len()) | |||
There was a problem hiding this comment.
Just a small optimization after re-reading our buffer pool logic.
pkwarren
changed the title
pkwarren
changed the title
jchadwick-buf
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thinking about it, this seems logical enough to me. If the buffer is never returned, then it's effectively just deferring the allocation to later in most cases. Right? So this is not really making the GC/allocation load any worse, it's just changing when the alloc inevitably happens. (Maybe in some cases that is still desired?)
In addition, I think this particular make+copy pattern is optimized by gc and makes it marginally faster than other options for copying data. Though, it could be getting pessimized by the function call to data.Bytes() happening during the copy. Given that this is in a hot path, it might just be worth looking into.
renovate bot
referenced
this pull request
in open-feature/flagd
Jun 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bufbuild/connect-go](https://togithub.com/bufbuild/connect-go) | require | minor | `v1.8.0` -> `v1.9.0` | --- ### Release Notes <details> <summary>bufbuild/connect-go (github.com/bufbuild/connect-go)</summary> ### [`v1.9.0`](https://togithub.com/bufbuild/connect-go/releases/tag/v1.9.0) [Compare Source](https://togithub.com/bufbuild/connect-go/compare/v1.8.0...v1.9.0) #### What's Changed Along with a few new features and bugfixes, this release includes a variety of internal performance improvements. [v1.8.0] BenchmarkConnect/unary-12 8415 1305116 ns/op 14449031 B/op 254 allocs/op [v1.9.0] BenchmarkConnect/unary-12 10443 1151366 ns/op 6024079 B/op 236 allocs/op ##### Enhancements - Allow clients to set Host in headers by [@​emcfarlane](https://togithub.com/emcfarlane) in [https://github.com/bufbuild/connect-go/pull/522](https://togithub.com/bufbuild/connect-go/pull/522) - Allow Connect clients to configure max HTTP GET size by [@​jhump](https://togithub.com/jhump) in [https://github.com/bufbuild/connect-go/pull/529](https://togithub.com/bufbuild/connect-go/pull/529) - Reduce allocations in HTTP routing by [@​mattrobenolt](https://togithub.com/mattrobenolt) in [https://github.com/bufbuild/connect-go/pull/519](https://togithub.com/bufbuild/connect-go/pull/519) - Cache mapping of methods to protocol handlers by [@​emcfarlane](https://togithub.com/emcfarlane) in [https://github.com/bufbuild/connect-go/pull/525](https://togithub.com/bufbuild/connect-go/pull/525) - Improve performance of percent encoding by [@​emcfarlane](https://togithub.com/emcfarlane) in [https://github.com/bufbuild/connect-go/pull/531](https://togithub.com/bufbuild/connect-go/pull/531) - Reduce marshaling allocations with MarshalAppend by [@​emcfarlane](https://togithub.com/emcfarlane) in [https://github.com/bufbuild/connect-go/pull/503](https://togithub.com/bufbuild/connect-go/pull/503) ##### Bugfixes - Discard unknown JSON fields by default by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/518](https://togithub.com/bufbuild/connect-go/pull/518) - Canonicalize Connect streaming trailer names by [@​jchadwick-buf](https://togithub.com/jchadwick-buf) in [https://github.com/bufbuild/connect-go/pull/528](https://togithub.com/bufbuild/connect-go/pull/528) ##### Other changes - Tighten internal lint checks by [@​zchee](https://togithub.com/zchee) in [https://github.com/bufbuild/connect-go/pull/520](https://togithub.com/bufbuild/connect-go/pull/520) - Simplify code when pooled buffers aren't returned by [@​pkwarren](https://togithub.com/pkwarren) in [https://github.com/bufbuild/connect-go/pull/532](https://togithub.com/bufbuild/connect-go/pull/532) #### New Contributors - [@​zchee](https://togithub.com/zchee) made their first contribution in [https://github.com/bufbuild/connect-go/pull/520](https://togithub.com/bufbuild/connect-go/pull/520) - [@​emcfarlane](https://togithub.com/emcfarlane) made their first contribution in [https://github.com/bufbuild/connect-go/pull/522](https://togithub.com/bufbuild/connect-go/pull/522) **Full Changelog**: bufbuild/connect-go@v1.8.0...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDEuMyIsInVwZGF0ZWRJblZlciI6IjM1LjE0MS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some error handling cases, we're retrieving a value from the sync.Pool and explicitly not returning it. Instead, we might simplify things and just allocate a buffer (since we already know the size) and use it and not put extra work on the pool to garbage collect objects that are retrieved but never returned.