Fix WithCompression to match docs; add tests #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
Apr 6, 2023
akshayjshah
approved these changes
Apr 6, 2023
…th respect to nil constructors
renovate bot
referenced
this pull request
in open-feature/flagd
Apr 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bufbuild/connect-go](https://togithub.com/bufbuild/connect-go) | require | minor | `v1.6.0` -> `v1.7.0` | --- ### Release Notes <details> <summary>bufbuild/connect-go</summary> ### [`v1.7.0`](https://togithub.com/bufbuild/connect-go/releases/tag/v1.7.0) [Compare Source](https://togithub.com/bufbuild/connect-go/compare/v1.6.0...v1.7.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed As of this release, the Connect protocol supports performing idempotent, side-effect free requests using HTTP GETs. This makes it easier to cache responses in the browser, on your CDN, or in proxies and other middleboxes. > **Note** > This functionality is *only* supported when using the Connect protocol—using a Connect client with a Connect server. When using `grpc-go` clients, or `connect-go` clients configured with the `WithGRPC` or `WithGRPCWeb` options, all requests will continue to be HTTP POSTs. To opt into GET support for a given Protobuf RPC, you must mark it as being side-effect free using the [MethodOptions.IdempotencyLevel](https://togithub.com/protocolbuffers/protobuf/blob/e5679c01e8f47e8a5e7172444676bda1c2ada875/src/google/protobuf/descriptor.proto#L795) option: ```proto service ElizaService { rpc Say(stream SayRequest) returns (SayResponse) { option idempotency_level = NO_SIDE_EFFECTS; } } ``` With this schema change, handlers will automatically support both GET and POST requests for this RPC. However, clients will continue to use POST requests by default, even when GETs are possible. To make clients use GETs for side effect free RPCs, use the `WithHTTPGet` option: ```go client := elizav1connect.NewElizaServiceClient( http.DefaultClient, connect.WithHTTPGet(), ) ``` This functionality is *not* yet supported by other Connect implementations (including `connect-es`), but hang tight! We're working on it. For more information, please check the [full documentation](https://connect.build/docs/go/get-requests-and-caching). ##### Enhancements - Connect HTTP Get support by [@​jchadwick-buf](https://togithub.com/jchadwick-buf) in [https://github.com/bufbuild/connect-go/pull/478](https://togithub.com/bufbuild/connect-go/pull/478) - Add APIs to make and handle conditional GETs by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/494](https://togithub.com/bufbuild/connect-go/pull/494) ##### Bugfixes - Fix `WithCompression` to match docs by [@​jhump](https://togithub.com/jhump) in [https://github.com/bufbuild/connect-go/pull/493](https://togithub.com/bufbuild/connect-go/pull/493) **Full Changelog**: bufbuild/connect-go@v1.6.0...v1.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDkuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Update doc comments and add tests, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492.