Send gRPC error metadata only as HTTP trailers #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #406, I was too cavalier about `net/http.ResponseWriter`'s API to send HTTP trailers. Because we're not calling `WriteHeader` before between predeclaring our trailers and actually setting the trailer values, we end up sending the same data as both HTTP headers and trailers.
pkwarren
approved these changes
Dec 2, 2022
rhbuf
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
I found an example where they illustrate this behaviour.
lgtm after ci fixes
renovate bot
referenced
this pull request
in open-feature/flagd
Jan 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bufbuild/connect-go](https://togithub.com/bufbuild/connect-go) | require | minor | `v1.3.1` -> `v1.4.1` | --- ### Release Notes <details> <summary>bufbuild/connect-go</summary> ### [`v1.4.1`](https://togithub.com/bufbuild/connect-go/releases/tag/v1.4.1) [Compare Source](https://togithub.com/bufbuild/connect-go/compare/v1.4.0...v1.4.1) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Bugfixes - Ensure server reflection can always access protobuf descriptors by [@​joshcarp](https://togithub.com/joshcarp) in [https://github.com/bufbuild/connect-go/pull/418](https://togithub.com/bufbuild/connect-go/pull/418) - Don't clobber custom User-Agents by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/423](https://togithub.com/bufbuild/connect-go/pull/423) **Full Changelog**: bufbuild/connect-go@v1.4.0...v1.4.1 ### [`v1.4.0`](https://togithub.com/bufbuild/connect-go/releases/tag/v1.4.0) [Compare Source](https://togithub.com/bufbuild/connect-go/compare/v1.3.2...v1.4.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Enhancements - Improve panic message on invalid handler returns by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/415](https://togithub.com/bufbuild/connect-go/pull/415) - Add support for Connect-Protocol-Version header by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/416](https://togithub.com/bufbuild/connect-go/pull/416) #### Migration Notes As a consequence of [https://github.com/bufbuild/connect-go/pull/416](https://togithub.com/bufbuild/connect-go/pull/416), `connect-go` servers exposed to web browsers may need to amend their CORS configuration to add `Connect-Protocol-Version` to `Access-Control-Allow-Headers`. The [pull request description](https://togithub.com/bufbuild/connect-go/pull/416) explains the motivation for this additional header. **Full Changelog**: bufbuild/connect-go@v1.3.2...v1.4.0 ### [`v1.3.2`](https://togithub.com/bufbuild/connect-go/releases/tag/v1.3.2) [Compare Source](https://togithub.com/bufbuild/connect-go/compare/v1.3.1...v1.3.2) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Bugfixes - Send gRPC error metadata only as HTTP trailers by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/410](https://togithub.com/bufbuild/connect-go/pull/410) **Full Changelog**: bufbuild/connect-go@v1.3.1...v1.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45Ny42IiwidXBkYXRlZEluVmVyIjoiMzQuOTcuNiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
In #406, I was too cavalier about `net/http.ResponseWriter`'s API to send HTTP trailers. Because we're not calling `WriteHeader` before between predeclaring our trailers and actually setting the trailer values, we end up sending the same data as both HTTP headers and trailers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #406, I was too cavalier about
net/http.ResponseWriter's API tosend HTTP trailers. Because we're not calling
WriteHeaderbeforebetween predeclaring our trailers and actually setting the trailer
values, we end up sending the same data as both HTTP headers and
trailers.