Close conn when HTTP/1.1 clients call bidi methods #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an HTTP/1.1 client calls a bidi RPC method, the caller has likely written application-level code that expects a full-duplex stream. Unless the server closes the TCP connection, the client code will often end up blocked because it's trying to read the response before it closes the request body.
jhump
approved these changes
Nov 30, 2022
joshcarp
approved these changes
Nov 30, 2022
timostamm
referenced
this pull request
in connectrpc/connect-es
Nov 30, 2022
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
If an HTTP/1.1 client calls a bidi RPC method, the caller has likely written application-level code that expects a full-duplex stream. Unless the server closes the TCP connection, the client code will often end up blocked because it's trying to read the response before it closes the request body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an HTTP/1.1 client calls a bidi RPC method, the caller has likely written application-level code that expects a full-duplex stream. Unless the server closes the TCP connection, the client code will often end up blocked because it's trying to read the response before it closes the request body.