Fix panic on zero send from server #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcarp
requested review from
pkwarren and
akshayjshah
and removed request for
pkwarren
pkwarren
reviewed
Nov 18, 2022
akshayjshah
approved these changes
Nov 18, 2022
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
- Maps a zero code of `connectWireError` to a CodeUnknown in `connectWireError) asError() *Error ` This could have been done in the unmarshaling to `connectWireError` but I chose to leave that to be exactly what was read off the wire. - Adds nil guard in `validateResponse` for asError - Adds tests for error mapping Fixes: https://github.com/bufbuild/connect-go/issues/396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectWireErrorto a CodeUnknown inconnectWireError) asError() *ErrorThis could have been done in the unmarshaling to
connectWireErrorbut I chose to leave that to be exactly what was read off the wire.validateResponsefor asErrorFixes: https://github.com/bufbuild/connect-go/issues/396