Bump test coverage to 90% #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
reviewed
Nov 16, 2022
joshcarp
commented
Nov 17, 2022
added 14 commits
November 17, 2022 08:20
joshcarp
changed the title
akshayjshah
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Awesome 🎉 Thank you for taking this on, @joshcarp!
Once you make the suggested changes and tests/lint/etc are passing, go ahead and merge this.
| connectClient := pingv1connect.NewPingServiceClient(server.Client(), server.URL) | ||
| connectResp, err := connectClient.Ping(context.Background(), connect.NewRequest(&pingv1.PingRequest{})) | ||
| assert.NotNil(t, err) | ||
| assert.Nil(t, connectResp) |
There was a problem hiding this comment.
Do these last four lines test anything that's not covered elsewhere?
There was a problem hiding this comment.
Yes actually; the client panics when the server sends a zero connect error code which has an open issue at the moment: https://github.com/bufbuild/connect-go/issues/396
You can't get the http status code from a connect unary client (that I know of) so doing both was the only way I came up with
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Adds more tests to 90% test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds misc tests, almost to 90%