Add buf format and make lintfix a dependency of generate #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doriable
approved these changes
Mar 25, 2022
akshayjshah
reviewed
Mar 25, 2022
There was a problem hiding this comment.
Yes! Love that we have formatting now 😻
I'd prefer not to make lintfix a dependency of the build - it makes it impossible to generate code if there are any invalid Go files around. Can we instead make buf format -d part of lint, just like gofmt, and keep buf format -w part of lintfix?
|
@bufdev updated a bit, WDYT? |
|
Eh....sure, I'll survive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.