Delete versions from generated code

[bufdev]

I think this was just doing what protoc-gen-go-grpc was doing (?). This deletes the versions from the generated code and capitalizes "Source":

-// versions:
-// - protoc-gen-connect-go v0.0.1
-// - protoc              (unknown)
-// source: connect/ping/v1test/ping.proto
+//
+// Source: connect/ping/v1test/ping.proto

Having these in the generated code is a constant source of frustration for people, it means that every time you do an upgrade of connect, you get a huge diff, and in theory for no reason - we only really care about whether the file is compatible or not, which we get through the compile-time assertion with IsAtLeast*. There's an argument to keep the protoc-gen-connect-go version, as this could be useful information for debugging, especially if using i.e. BSR remote generation, but the protoc version definitely should go IMO - you shouldn't have to care what version of protoc you are using outside of using the builtin plugins (java, cpp, etc). Even more to the point, buf stopped emitting a protoc version, so this will always be (unknown) with buf.

If we do want to keep the protoc-gen-connect-go version, I'd argue to do it in the form that Twirp does, inlining it in the Code generated by line https://github.com/twitchtv/twirp/blob/main/example/service.twirp.go#L1

[akshayjshah]

Yep, I just did what the grpc-go plug-in did. Happy to do something better.

[bufdev]

I say we try this out for a bit, but we might want to re-add the protoc-gen-connect-go version before release, re: my debate above - I can see an argument for that, but it might just be because we're so used to it that it's hard to give it up.

[akshayjshah]

Works for me.

…

On Sat, Mar 5, 2022 at 8:45 AM bufdev ***@***.***> wrote: I say we try this out for a bit, but we might want to re-add the protoc-gen-connect-go version before release, re: my debate above - I can see an argument for that, but it might just be because we're so used to it that it's hard to give it up. — Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHNP5XE27C5I4P4GSZ6D33U6OFTBANCNFSM5P74RY7A> . You are receiving this because your review was requested.Message ID: ***@***.***>