Update dependencies #928
Update dependencies #928
Conversation
|
@timostamm not sure how you want to handle these issues. I took a stab at mitigating them, but if you have other ideas, let me know. I put this in its own PR just so it was easier to evaluate the fixes without muddying up the release PR. |
There was a problem hiding this comment.
karma-esbuild is somehow broken when updating it alongside karma and esbuild.
This seems odd, since the karma-esbuild release has been out for a while without new issue reports, and there have been forks as well.
It would be helpful to add the exact error message here in cases like this, so that others who might know more about the issue can chime in.
Was it this error?
ERROR [plugin]: Cannot load "esbuild", it is not registered!
Perhaps you are missing some plugin?
Karma auto-registers plugins from packages in node_modules when their name starts with "karma-". If karma-esbuild is installed nested in a workspace, karma installed from the root package won't find it. If I make sure that karma-esbuild is in the top level node_modules next to karma, make testwebbrowser passes for me.
Please give this another try, but make sure to update esbuild everywhere, so that karma-esbuild is hoisted into the root node_modules.
|
Can you name this PR "Update dependencies"? |
|
@timostamm incorporated your feedback. Lmk how it looks. |
This prepares for the v1.2.0 release by accounting for some issues that arose during the release process. Since the process removes
package-lock.jsonand causes deps to be updated, some of the updated deps are causing the build to fail.To prepare, the
package-lock.jsonandnode_modulesdirectory were removed andnpm installwas run. Then,makewas run to discover any issues, which were as follows:@typescript/eslint added a new rule in v6.11.0 which fails when comparing an enum type against a different type. This causes a function in
connect-nodeto fail. So, the rule has been disabled for that function.karma-esbuild is somehow broken when updating it alongside karma and esbuild. Since Karma itself is deprecated and karma-esbuild sat stagnant for over a year (until the latest release which is causing the issues), it's probably best to just pin to the one on main until we can move off of Karma asap.