Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for Nestjs #986

Closed
wants to merge 1 commit into from

Conversation

stevenceuppens
Copy link

Draft Proposal

New connect-nest package to natively support Buf Connect in Nestjs.

This packages uses NestMiddleware to integrate with Buf Connect with the underlying express or fastify server (agnostic implementation).

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

@stevenceuppens stevenceuppens marked this pull request as draft January 23, 2024 01:41
@srikrsna-buf
Copy link
Member

Hey! Thank you for the PR!

We are discussing how to handle framework integrations going forward. I'd suggest holding off until I get back to you with how we want to incorporate such packages.

@srikrsna-buf
Copy link
Member

@stevenceuppens Can you open an RFC similar to this one proposing a new repo for the nestjs framework? We are not familiar with nestjs and would like someone with nestjs experience to be a co-maintainer of that repo, are you open to maintaining it in the long term?

@srikrsna-buf
Copy link
Member

@stevenceuppens closing this issue, please open an RFC if you want to add the package. Thanks!

@boan-anbo
Copy link

Good effort but this won't give access to DI to the Connect endpoints, they will end up with undefined injected services because it's currently used as global middleware.

https://docs.nestjs.com/middleware#global-middleware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants