Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase grace period for deadline propagation #913

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Increase grace period for deadline propagation #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions internal/app/connectconformance/results.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,17 @@ import (
"google.golang.org/protobuf/types/known/anypb"
)

// CI environments have been observed to have 150ms of delay between the deadline
// being set and it being serialized in a request header. This adds a little extra
// headroom to avoid flaky tests.
const timeoutCheckGracePeriodMillis = 250
// In tests for deadline propagation, the client sends a request with a timeout
// and has the server report the timeout in the response. The test runner then
// compares the reported timeout against the requested timeout.
// However, servers typically start counting down from the original timeout as
// soon as request headers arrive, and provide only the _remaining_ time via
// their API. It is therefore to be expected that the server reports a smaller
// value than the requested timeout, depending on the time spent processing the
// request body and preparing the response.
// CI environments have been observed to have up to 350ms of delay. This adds a
// little extra headroom to avoid flaky tests.
const timeoutCheckGracePeriodMillis = 500

// testResults represents the results of running conformance tests. It accumulates
// the state of passed and failed test cases and also reports failures to a given
Expand Down
Loading