Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all import aliases consistent #799

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Make all import aliases consistent #799

merged 2 commits into from
Feb 20, 2024

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Feb 20, 2024

This makes all import aliases for the Conformance protos consistent. Previously, there was a mix of v1 and conformancev1 and this ensures they're all conformancev1.

@smaye81 smaye81 requested a review from jhump February 20, 2024 18:56
jhump
jhump approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might easiest to land #792 first, and then rebase this. I saw some new references to v1. prefixes in that PR with some of the code changes.

@smaye81 smaye81 merged commit 5afc747 into main Feb 20, 2024
4 checks passed
@smaye81 smaye81 deleted the sayers/fix_import_aliases branch February 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhump jhump jhump approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smaye81 @jhump