Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher grace period for deadline propagation #782

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jhump
Copy link
Member

@jhump jhump commented Feb 8, 2024

This is to combat flaky tests. The existing threshold of 100ms is not always sufficient. Here's a recent failure, where the actual delta was 135ms: https://github.com/connectrpc/conformance/actions/runs/7832580880/job/21371604793?pr=781

@jhump jhump requested a review from smaye81 February 8, 2024 16:36
@jhump jhump enabled auto-merge (squash) February 8, 2024 16:51
@jhump jhump merged commit dd1411f into main Feb 8, 2024
4 checks passed
@jhump jhump deleted the jh/less-flaky-deadline-tests branch February 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants