Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test runner needs to add synthetic headers to raw request, too #758

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

jhump
Copy link
Member

@jhump jhump commented Jan 20, 2024

These are extra headers used by the reference server, to verify that the client created the request in the expected way. They were previously only added to the structured request that normal clients use. But it also needs to be included in the raw request, for test cases that use raw requests with the reference client.

This also makes it so that the test case name header is always added, even when not running against the reference server. This is useful if tracing through and debugging an implementation -- you can easily tell which test case the request is for because it is always in the request headers.

@jhump jhump requested a review from smaye81 January 20, 2024 21:50
@jhump jhump enabled auto-merge (squash) January 22, 2024 18:18
@jhump jhump merged commit 1b134c1 into main Jan 22, 2024
4 checks passed
@jhump jhump deleted the jh/headers branch January 22, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants