Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout tests for Bidi #716

Merged
merged 21 commits into from
Nov 29, 2023
Merged

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Nov 29, 2023

This adds two timeout tests for Bidi streams. Note though, that Bidi timeouts are currently failing in gRPC due to an issue with properly wrapping context deadline errors on the client side. As a result, these tests are only running for Connect and gRPC-Web.

Once the issue with context deadlines is addressed, these tests will be modified to run on all protocols.

@smaye81 smaye81 requested a review from jhump November 29, 2023 16:04
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smaye81 smaye81 merged commit 88d4edd into sayers/response_def Nov 29, 2023
@smaye81 smaye81 deleted the sayers/bidi_timeouts branch November 29, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants