Add support for specifying timeouts #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds [goreleaser](https://goreleaser.com/) to the repo to enable easy publishing of releases.
smaye81
commented
Nov 28, 2023
| @@ -359,6 +359,15 @@ func populateExpectedResponse(testCase *conformancev1.TestCase) error { | |||
| } | |||
| } | |||
|
|
|||
| // Converts a pointer to a uint32 value into a pointer to an int64. | |||
| // If the pointer is nil, function returns nil. | |||
| func convertToInt64Ptr(num *uint32) *int64 { | |||
There was a problem hiding this comment.
Not sure if there's a better way to do this.
smaye81
commented
Nov 28, 2023
| @@ -140,6 +144,9 @@ message UnaryResponseDefinition { | |||
| // Response trailers to send - together with the error if present | |||
| repeated Header response_trailers = 4; | |||
|
|
|||
| // Wait this many milliseconds before sending a response message | |||
| uint32 response_delay_ms = 6; | |||
There was a problem hiding this comment.
Realized there was no way to specify a response delay for unary responses.
smaye81
commented
Nov 28, 2023
| @@ -73,6 +73,21 @@ testCases: | |||
| responseTrailers: | |||
| - name: x-custom-trailer | |||
| value: ["bing","quux"] | |||
| - request: | |||
There was a problem hiding this comment.
Bidi's seem to be failing timeouts. Investigating in a separate PR.
jhump
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying timeouts and adds unit tests for validating context deadlines. In doing so, it fixes the expectations so that the test library validates servers are returning the received
TimeoutMs.