-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connect-node-fastify server #477
Conversation
@@ -1,3 +1,3 @@ | |||
version: v1 | |||
directories: | |||
- internal/proto | |||
- proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a reasonable change, but we have at least one command using the old path here. I'm not sure what Kotlin and Swift do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can fix that path once this lands. I checked both repos and they do not seem to rely on that path. Also followed up with Alan and Rebello to verify.
Co-authored-by: Timo Stamm <[email protected]>
This adds a new Connect server using
connect-fastify
andconnect-node
. It wires it into the docker-compose setup and allows for serving HTTP/1.1 and HTTP/2 traffic using cleartext and TLS. Fastify does not offer HTTP/3 support as of yet, so that path is not available. Note: this does not yet use TLS, but can be added as a follow-up PR.In addition, this also refactors a few things such as:
client-connect-to-server-connect-go-h2
becomesclient-connect-go-to-server-connect-go-h2
and usesDockerfile.crosstestgo
instead ofDockerfile.crosstest
.