Fix If CACertificatePath Is Empty, Verification Fails #932
+258
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckorben
commented
Feb 4, 2025
| if (string.IsNullOrEmpty(_socketSettings.CACertificatePath)) { | ||
| _nonSessionLog.OnEvent("CACertificatePath is not specified"); | ||
| return false; |
There was a problem hiding this comment.
This is the root of the problem. SslStream provides public certificate validation via SslPolicyErrors before we get here. This return false causes this function to fail for all public certificates. Instead, we should validate SslPolicyErrors for both public and private certs.
Why this behavior changed from older versions is what I haven't figured out
There was a problem hiding this comment.
This logic ended up being changed by #827. It appears unintentional.
I'm surprised more people haven't run into this because with the change in logic you'll get AuthenticationException "The remote certificate was rejected by the provided RemoteCertificateValidationCallback" throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #895.
Added Tests for Local Certificate with CA