Merge pull request #55 from ndr-brt/fix/fix-utils-tests

fix(test): fix utils.js tests

src/tests/utils.test.js

@@ -1,17 +1,33 @@
+jest.mock('../storage.js');
+const getBanList = require('../storage.js').getBanList;
+
 const utils = require("../utils");
 
 describe("isPackageNameBanned Tests", () => {
-  // Now since the editor is started in development mode for testing, we know
-  // banned package lists will fallback to a static list here.
+
   test("Returns true correctly for banned item", async () => {
-    let name = "situs-slot-gacor";
+    getBanList.mockResolvedValue({ ok: true, content: ['banned-item'] });
+    let name = "banned-item";
+
     let isBanned = await utils.isPackageNameBanned(name);
-    expect(isBanned).toBeTruthy();
+
+    expect(isBanned.ok).toBeTruthy();
   });
 
   test("Returns false correctly for non-banned item", async () => {
-    let name = "innocent-name";
+    getBanList.mockResolvedValue({ ok: true, content: ['banned-item'] });
+    let name = "not-banned-item";
+
     let isBanned = await utils.isPackageNameBanned(name);
-    expect(isBanned).toBeFalsy();
+
+    expect(isBanned.ok).toBeFalsy();
   });
+
+  test("Returns true if no banned list can be retrieved", async () => {
+    getBanList.mockResolvedValue({ ok: false });
+
+    let isBanned = await utils.isPackageNameBanned('any');
+
+    expect(isBanned.ok).toBeTruthy();
+  })
 });

src/utils.js

@@ -18,23 +18,16 @@ const { server_url } = require("./config.js").getConfig();
  * @returns {boolean} Returns true if the given name is banned. False otherwise.
  */
 async function isPackageNameBanned(name) {
-  let names = await storage.getBanList();
-
-  if (!names.ok) {
+  let banList = await storage.getBanList();
+  if (!banList.ok) {
     // we failed to find the ban list. For now we will just return ok.
     logger.warningLog(null, null, "Unable to locate Name Ban List");
     return { ok: true };
   }
 
-  for (let i = 0; i < names.content.length; i++) {
-    if (name === names.content[i]) {
-      // it was found on a ban list.
-      return { ok: false };
-    }
-  }
-
-  // name wasn't found on any ban lists.
-  return { ok: true };
+  return banList.content.find(b => name === b)
+    ? { ok: true }
+    : { ok: false };
 }
 
 /**