Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display name generator to ensure Kraft is used in integration tests #3529

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Jan 24, 2025

What

Add display name generator to ensure Kraft is used in integration tests, since the underlying QuorumTestHarness keys off of the display name.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Is this change gated behind feature flag(s)?
    • List the LD flags needed to be set to enable this change
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
  • Does this change require modifying existing system tests or adding new system tests?
    • If so, include tracking information for the system test changes

References

JIRA:

Test & Review

Open questions / Follow-ups

@rayokota rayokota requested a review from a team as a code owner January 24, 2025 21:47
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (72.90% Estimated after merge)
  • Duplications No duplication information (2.10% Estimated after merge)

Project ID: schema-registry

View in SonarQube

@rayokota rayokota merged commit ea05961 into master Jan 24, 2025
4 checks passed
@rayokota rayokota deleted the add-display-name branch January 24, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants