Remove the single static ConfigDef from RestConfig. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, provide a way to generate the equivalent ConfigDef. This allows subclasses to ensure they have their own ConfigDef to work with. Previously, if you had two RestConfig subclasses in the same process, they would share the same ConfigDef, which easily leads to conflicts.
|
@nehanarkhede Going to need this for Avro support in kafka-rest. Turns out that if you try to run both in the same process their config classes conflict... |
ewencp
added a commit
to confluentinc/schema-registry
that referenced
this pull request
Jan 29, 2015
This change is required by confluentinc/rest-utils#8 and avoids conflicts with other subclasses of RestConfig.
|
@ewencp LGTM |
ewencp
added a commit
that referenced
this pull request
Jan 29, 2015
Remove the single static ConfigDef from RestConfig.
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Prince Raheja <[email protected]> Co-authored-by: ConfluentSemaphore <[email protected]>
ehumber
added a commit
that referenced
this pull request
Sep 10, 2024
CPBR-1680: adding cp-jar-build block for PR builds (#492) (#8)
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Prince Raheja <[email protected]> Co-authored-by: ConfluentSemaphore <[email protected]>
ehumber
added a commit
that referenced
this pull request
Sep 12, 2024
CPBR-1680: adding cp-jar-build block for PR builds (#492) (#8) (#10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, provide a way to generate the equivalent ConfigDef. This allows
subclasses to ensure they have their own ConfigDef to work with. Previously, if
you had two RestConfig subclasses in the same process, they would share the same
ConfigDef, which easily leads to conflicts.