Fix timestamp extraction for compressed messages #858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjing
force-pushed
the
yunjing.compress.ts
branch
from
4fc2993 to
5576b5a
Compare
|
@edenhill any suggestion on this? We are trying to open source a project in a week, but this bug is blocking us. |
|
Hey, I'll look at this during the weekend and get back to you. |
|
Thanks @edenhill. Really appreciated! |
|
Hi, we've just pushed an open source project for which we require these changes in order to run in production: https://github.com/smyte/kafka_store For now we're recommending that users install our fork, which we'll revert as soon as this makes it into a release. |
edenhill
added a commit
that referenced
this pull request
Nov 16, 2016
edenhill
added a commit
that referenced
this pull request
Nov 16, 2016
|
Thanks! |
|
Can you verify the fix on your end, thanks? |
|
Verified that it worked by compiling kafkacat with librdkafka master and consuming from several topics in production. We have not yet incorporated the latest librdkafka in our production services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently timestamp extraction fails for compressed messages. It would report
-1instead of the actual timestamp because the timestamps for compressed messages are stored at the block level. This PR passes down the header for the block to each of the uncompressed messages.