Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 4438 to 2.2.0 #4914

Merged
merged 10 commits into from
Dec 15, 2024
Merged

Conversation

anchitj
Copy link
Member

@anchitj anchitj commented Nov 26, 2024

Removed 0143 test references.

Also backported #4775, #4872, #4794 to make CI pass.

Backported #4726, #4706, #4875 to upgrade linux dependencies.

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_backport_idempotent_fix_2.2.0 branch from 8f9dc66 to 7ff425f Compare November 26, 2024 14:49
*Remove CentOS 6 and 7 support as discontinued, keeps
  using manylinux_2_28 based on AlmaLinux 8 (CentOS 8)
* Remove fix for CentOS 6
* Add CHANGELOG entry
* Upgrade test and verify package creation or installation
   using clients repository
and add build checks with different configurations
@anchitj anchitj changed the title Fix for idempotent producer fatal errors, triggered after a possibly … Backport 4438 to 2.2.0 Nov 29, 2024
@anchitj anchitj marked this pull request as ready for review November 29, 2024 07:13
CHANGELOG.md Outdated
@@ -25,7 +25,8 @@ librdkafka v2.2.0 is a feature release:
Add DNS alias support for secured connection (#4292).
* [KIP-339](https://cwiki.apache.org/confluence/display/KAFKA/KIP-339%3A+Create+a+new+IncrementalAlterConfigs+API):
IncrementalAlterConfigs API (started by @PrasanthV454, #4110).
* [KIP-554](https://cwiki.apache.org/confluence/display/KAFKA/KIP-554%3A+Add+Broker-side+SCRAM+Config+API): Add Broker-side SCRAM Config API (#4241).
* [KIP-554](https://cwiki.apache.org/confluence/display/KAFKA/KIP-554%3A+Add+Broker-side+SCRAM+Config+API): Add Broker-side SCRAM Config API (#4241).
* Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (#4438).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix should go in a 2.2.1 maintenance release with only this item

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is customer using Windows only? Otherwise we should upgrade Linux dependencies too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RD_KAFKA_VERSION must be changed to 020201 and version in vcpkg.json must be 2.2.1 too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the changelog to v.2.2.1 and updated RD_KAFKA_VERSION

Copy link
Contributor

@emasab emasab Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change RD_KAFKA_VERSION in rdkafkacpp.h too, please

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_backport_idempotent_fix_2.2.0 branch from a1156e5 to 88388fd Compare December 15, 2024 09:43
milindl and others added 4 commits December 15, 2024 17:27
* Add files for lz4 1.9.4

* Update changelog.md

* rdxxhash should not be in clang-format list

* Add instructions and update memory alloc/free

* Update instructions for lz4
* update third party dependencies
* update lz4 version in the header file
* update libraries for the windows build
* reverting the version bump in the headers
* use the latest version of curl
* Update OpenSSL and add CHANGELOG.md
* downgade curl version to one available via vcpkg
* downgrade zlib to last available version in vcpkg
* downgrade zstd to the latest available
* Include CPPFLAGS within make for libcurl
* Update mklove/modules/configure.libcurl
* Update CHANGELOG.md

---------

Co-authored-by: Milind L <[email protected]>
Co-authored-by: Emanuele Sabellico <[email protected]>
* Security upgrade for OpenSSL and Curl, CVEs fixed:

OpenSSL
- CVE-2024-2511
- CVE-2024-4603
- CVE-2024-4741
- CVE-2024-5535
- CVE-2024-6119

CURL
- CVE-2024-8096
- CVE-2024-7264
- CVE-2024-6874
- CVE-2024-6197

* Fix for curl configure failure caused by
curl/curl#14373
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anchit, just this thing is missing.

CHANGELOG.md Outdated
@@ -25,7 +25,8 @@ librdkafka v2.2.0 is a feature release:
Add DNS alias support for secured connection (#4292).
* [KIP-339](https://cwiki.apache.org/confluence/display/KAFKA/KIP-339%3A+Create+a+new+IncrementalAlterConfigs+API):
IncrementalAlterConfigs API (started by @PrasanthV454, #4110).
* [KIP-554](https://cwiki.apache.org/confluence/display/KAFKA/KIP-554%3A+Add+Broker-side+SCRAM+Config+API): Add Broker-side SCRAM Config API (#4241).
* [KIP-554](https://cwiki.apache.org/confluence/display/KAFKA/KIP-554%3A+Add+Broker-side+SCRAM+Config+API): Add Broker-side SCRAM Config API (#4241).
* Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (#4438).
Copy link
Contributor

@emasab emasab Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change RD_KAFKA_VERSION in rdkafkacpp.h too, please

@anchitj
Copy link
Member Author

anchitj commented Dec 15, 2024

Updated in rdkafkacpp.h

@anchitj anchitj merged commit 2f3d0e6 into release/v2.2.x Dec 15, 2024
2 checks passed
@anchitj anchitj deleted the dev_backport_idempotent_fix_2.2.0 branch December 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants