Change linger.ms default from 0.5 to 5ms to improve efficiency
#2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased batching leads to less protocol overhead, less CPU usage on client and brokers, increased throughput and in some cases also improved latency.
mhowlett
reviewed
Jul 8, 2020
| * The default producer batch accumulation time, `linger.ms`, has been changed | ||
| from 0.5ms to 5ms to improve batch sizes and throughput while reducing | ||
| the per-message protocol overhead. | ||
| Applications that require lower produce latency than 5ms will need to |
There was a problem hiding this comment.
pedantically, this is of course more complicated, at higher throughputs they'll get better latency with 5ms linger.ms than 0.5ms. but doesn't matter...
mhowlett
reviewed
Jul 8, 2020
| @@ -3645,15 +3645,20 @@ const char *rd_kafka_topic_conf_finalize (rd_kafka_type_t cltype, | |||
|
|
|||
|
|
|||
| if (cltype == RD_KAFKA_PRODUCER) { | |||
| if (tconf->message_timeout_ms != 0 && | |||
| (double)tconf->message_timeout_ms <= | |||
| conf->buffering_max_ms_dbl) { | |||
There was a problem hiding this comment.
if buffering_max_ms_dbl was named linger_ms_dbl i would have read this quite a bit more quickly. thought the thought, so thought i'd mention it.
mhowlett
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased batching leads to less protocol overhead, less CPU usage
on client and brokers, increased throughput and in some cases also
improved latency.