configure: Add option to disable automagic dependency on zstd #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
reviewed
Apr 29, 2019
mklove/modules/configure.zstd
Outdated
| function manual_checks { | ||
| local action=$1 | ||
| local action=${1:-disable} |
This commit will add an option which will allow you to explicit disable zstd usage.
edenhill
reviewed
Jul 12, 2019
| function manual_checks { | ||
| local action=$1 | ||
| local action=${1:-disable} |
There was a problem hiding this comment.
why is a default value needed? it is always passed an action
There was a problem hiding this comment.
Not the PR author, but I assume @Whissi is simply following the precedent set by libssl and libsasl2:
- https://github.com/edenhill/librdkafka/blob/b3223ecea638bfacc6d9ec981aa4df1d22ee9542/mklove/modules/configure.libssl#L22
- https://github.com/edenhill/librdkafka/blob/b3223ecea638bfacc6d9ec981aa4df1d22ee9542/mklove/modules/configure.libsasl2#L17
If this is indeed unnecessary, perhaps it should be removed from those other modules as well.
There was a problem hiding this comment.
Yes, that was my intention: Keep current style.
|
Not the PR author, but I'm interested in seeing this merged! Please see my response above. I actually think it would make sense to merge this as is for consistency with the other mklove lib modules and then if you'd like I can submit a follow-on PR to remove the default expansion across all of the mklove lib modules. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will add an option which will allow you to explicit disable
zstd usage.