Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Add check for C11 thread support. #2221

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

Oxymoron79
Copy link
Contributor

This PR adds a check in the CMake files to detect C11 thread support on the build host to enable the conditional compilation of tinycthread.
Glibc version 2.28 introduced support for C11 threads, which leads to similar problems as reported in #1998 on system that already use that Glibc version.

@edenhill
Copy link
Contributor

LGTM.
Is this good to go, @Oxymoron79 ?

@Oxymoron79
Copy link
Contributor Author

@edenhill Yes, it's good to go. The fix works on the systems that I tested.

@edenhill edenhill merged commit f460729 into confluentinc:master Feb 21, 2019
@edenhill
Copy link
Contributor

Thank you!

@Oxymoron79 Oxymoron79 deleted the cmake_check_c11_threads branch March 12, 2019 16:34
@edenhill
Copy link
Contributor

edenhill commented Mar 14, 2019

@Oxymoron79 This is unrelated to this issue, but the CMake builds are breaking because of missing BUILT_WITH define:
this was recently added to mklove as a string containing the WITH_x build options used for the build (without the WITH_ prefix).

Do you have any idea how to do this with CMake and would you like to take a stab at it?
If it turns out to be complicated we could just set it to "CMAKE", it is only used in an initial debug message to show the build options.

https://doozer.io/edenhill/librdkafka/buildlog/7044

@Oxymoron79
Copy link
Contributor Author

@edenhill Sure, I will try to find a solution in the next days. From a first quick look at the buildlog, I think it won't be hard to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants