-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free payload memory in rd_kafka_example when queue is full #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you create a new pull request containing only the fixes for rdkafka_example* and rdkafkacpp.h? |
Closed
Closed
9 tasks
9 tasks
9 tasks
This was referenced Dec 2, 2016
Closed
9 tasks
Closed
9 tasks
9 tasks
9 tasks
9 tasks
7 tasks
7 tasks
7 tasks
4 tasks
4 tasks
7 tasks
7 tasks
7 tasks
3 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Edenhill. I've learned a lot from discussion with you yesterday.
This patch is try to improve rd_kafka_example a little:
When queue is full due to max_outq_msg_cnt limit, opbuf is allocated but has no chance to deallocate in current code, and this patch fix this problem.
I'm not sure whether behavior in this patch is a little contradictory to RD_KAFKA_OP_F_FREE parameter in semantic. Realization in rd_kafka_produce prevent op_destroy to take effect.
int rd_kafka_produce (rd_kafka_t *rk, char *topic, uint32_t partition,
int msgflags,
char *payload, size_t len) {
rd_kafka_op_t *rko;