Release thread attr handles and block default route on compression #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default behaviour to a rd_kafka_assert Remove double * comments
|
Well after some fighting with rebasing some branches the wrong way, this should be rebased and changed with correct comment type and assert instead of abort. |
edenhill
added a commit
that referenced
this pull request
Apr 21, 2014
Release thread attr handles and silence compiler warnings (unreached compression.codec code path)
|
Thanks! |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release the thread attributes where were created with pthread_attr_init. According to the manual: "When a thread attributes object is no longer required, it should be destroyed using the pthread_attr_destroy() function. Destroying a thread attributes object has no effect on threads that were created using that object.". For the configuration of the compression add the default switch to block accidental invalid configuration settings since this would use an uninitialized variable.