kafka v0.6 support

[eugpermar]

Hi edenhill.

I'm trying to send messages between a producer and a consumer version of rdkafka_example through a kafka server, and no messages are given to the consumer. Kafka's version is 0.6, and I think that the problem right there.

Is there a way to send messages using this version of kafka using your library? If not, can I download a previous version or another library in C to do so? The language is very important because I want integrate kafka in a existing project.

Thanks and regards

[edenhill]

Try the 0.6 branch.

My rudimentary tests show that it works with kafka-0.6

[edenhill]

This commit fixes it:
bb9dbd3

[eugpermar]

Thanks Edenhill.
I have another question: The patch removes compression support, If we remove the compression field, librdkafka will remain compatible with kafka 0.7? Could we just put an if(), or maybe a preprocessor if, before the changes made in the bb9dbd3 to support both versions? (I don't care do it by myself)

By the way, I'm using librdkafka under C++, and I'm using a small wrapper to use it in a more POO way (it's just a header file for now) and I'd like to contribute with the project. Are you interested in include this file to provide a C++ interface?

Thanks and regards

[edenhill]

From what I understand message compression was added in 0.7, so it is not available in the 0.6 protocol.

It would be possible to modify the code to support both 0.6 and 0.7, but I'm not sure if it is worth the effort.
Most people are on 0.7, and 0.8 will be released in less than a month and thats where development efforts should be put. 0.6 is dated, soon two years old.

Do you need 0.6 and 0.7 support in the same application, simultanously? Otherwise you could link rdkafka statically and provide two versions of your application, one for 0.6 and for 0.7, disregarding how impractical that sounds.

[edenhill]

Re: C++

I'd be happy to receive a pull request providing a C++ interface!

[edenhill]

Please close this issue if the 0.6 branch fix solves your original issue.

[eugpermar]

Do you need 0.6 and 0.7 support in the same application, simultanously?
No I don't. In fact, kafka 0.6 support it's just transitional. We are migrating v0.6 to v0.7 bit by bit, and I just wondering it there is a easy way to do this. The commit is more than sufficient, Thanks!

I will close the issue and send you the pull request.