Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C11 thread check is not working with glibc 2.28 #2220

Closed
3 tasks done
Oxymoron79 opened this issue Feb 12, 2019 · 5 comments
Closed
3 tasks done

C11 thread check is not working with glibc 2.28 #2220

Oxymoron79 opened this issue Feb 12, 2019 · 5 comments

Comments

@Oxymoron79
Copy link
Contributor

Description

Glibc version 2.28 added support for C11 threads (see the release notes: https://www.sourceware.org/ml/libc-alpha/2018-08/msg00003.html).

But the check for C11 threads in configure.librdkafka (https://github.com/edenhill/librdkafka/blob/master/configure.librdkafka#L46) does not seem to
detect the C11 threads support on systems using glibc >= 2.28, because the link option
-lpthread is not used for the check.

I suspect that this leads to similar problems as #1998.

How to reproduce

On a system with glibc >= 2.28 (e.g. Arch Linux):

./configure
cat config.h | grep WITH_C11THREADS

WITH_C11THREADS is not defined in config.h, which leads to tinycthread being compiled without C11 thread support.

Checklist

Please provide the following information:

  • librdkafka version (release number or git tag): v0.11.1
  • Operating system: Arch Linux (x86_64)
  • Critical issue
@edenhill
Copy link
Contributor

Interesting, do you know of a docker image with glibc 2.28?

@Oxymoron79
Copy link
Contributor Author

Ubuntu 18.10 (Cosmic) seems to be shipping glibc 2.28: https://packages.ubuntu.com/cosmic/libc6
The cosmic tag of the ubuntu docker image should therefore include it: https://hub.docker.com/_/ubuntu

@Oxymoron79
Copy link
Contributor Author

@edenhill Were you able to reproduce the issue?

@grafitto
Copy link

grafitto commented Feb 21, 2019

I am also having the same error on Manjaro

@edenhill
Copy link
Contributor

This will be fixed in the upcoming v1.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants