Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on rd_kafka_q_serve_rkmessages #1863

Closed
1 task done
elbaro opened this issue Jun 27, 2018 · 5 comments
Closed
1 task done

Question on rd_kafka_q_serve_rkmessages #1863

elbaro opened this issue Jun 27, 2018 · 5 comments
Labels

Comments

@elbaro
Copy link

elbaro commented Jun 27, 2018

Read the FAQ first: https://github.com/edenhill/librdkafka/wiki/FAQ

Description

rd_kafka_q_serve_rkmessages has a parameter timeout_ms.
Is timeout_ms applied for batch or for a single message?

From the code, it looks like the timeout is applied for each message:
https://github.com/edenhill/librdkafka/blob/master/src/rdkafka_queue.c#L537-L551

If then, the request for batch_size=100, timeout_ms=1000 may timeout after 100*1000ms = 100 seconds.

Checklist

IMPORTANT: We will close issues where the checklist has not been completed.

Please provide the following information:

  • librdkafka version (release number or git tag): bd74dc3
@rnpridgeon
Copy link

relates to confluentinc/confluent-kafka-python#407

@edenhill
Copy link
Contributor

You are correct, this seems to be a bug. It should use the remaining timeout.

@edenhill edenhill added the bug label Jun 27, 2018
@manugarri
Copy link

hey @edenhill , is there any update on when we could expect a bugfix? If not we can really use batch consume reliably, right?

@edenhill
Copy link
Contributor

The fix PR will soon be submitted.
We've also got a couple of other fixes that warrants a maintenance release, so we'll probably create an RC next week.

@manugarri
Copy link

Awesome, thanks so much @edenhill ! We really want to use librdkafka since well. is the fastest library (and the one with the "official" confluent support). Very much looking forward to it Sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants