remove unused/old suppressions. reduce scope on some #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguy
approved these changes
Mar 12, 2018
norwood
force-pushed
the
suppressions-cleanup
branch
2 times, most recently
from
c8592d3 to
50abe1d
Compare
norwood
force-pushed
the
suppressions-cleanup
branch
from
50abe1d to
31e6970
Compare
rodesai
pushed a commit
that referenced
this pull request
Mar 20, 2018
apurvam
pushed a commit
that referenced
this pull request
Mar 20, 2018
hjafarpour
added a commit
that referenced
this pull request
May 11, 2018
* Cleaned up the grammar. * More clean up * Added parent reference to AST nodes. * remove unused/old suppressions. reduce scope on some (#915) * rename kafkaTopic->topic to match SourceInfo * proper typing for KafkaTopicInfo get rid of String encoded values. registered -> boolean replicaInfo -> list<int> instead of string encoding that info partitionCount -> gone since it is encoded in replicaInfo * Fix integration test annotations and remove maven-surefire-plugin overrides (#924) This includes one minor fix to the MetricsCollector to make it correctly robust to reuse across tests that are both aware of its initialization/cleanup and those that are not. * KSQL-739 return kafka cluster id as part of server info (#932) * reduce checkstyle suppressions (#938) * reduce checkstyle suppressions * remove commented out suppression * remove AbbreviationAsWordInName suppression (#937) * fix build (#946) * cluster id check subsumes broker compatibility (#959) clusterId metadata was introduced in Kafka 0.10.1 * Guava 21.0 -> 24.0 (#869) * Minor changes. * Merged with master. * Cleaned the merge! * More clean up. * More clean up. * Initialize the node parent to Optional.empty(). * Minor fix. * Applied review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.