Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change metrics tag #8268

Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix: change metrics tag #8268

merged 1 commit into from
Oct 20, 2021

Conversation

wcarlson5
Copy link
Contributor

Description

What behavior do you want to change, why, how does your patch achieve the changes?

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@wcarlson5 wcarlson5 marked this pull request as ready for review October 19, 2021 20:15
@wcarlson5 wcarlson5 requested a review from a team as a code owner October 19, 2021 20:15
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcarlson5 wcarlson5 merged commit caded5a into confluentinc:master Oct 20, 2021
@wcarlson5
Copy link
Contributor Author

@mjsax Can we pick this back to 0.22.x?

@wcarlson5 wcarlson5 deleted the change_metric_tag branch October 20, 2021 15:15
wcarlson5 added a commit that referenced this pull request Oct 20, 2021
(cherry picked from commit caded5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants