fix: During ksql startup, avoid recreating deleted command topic when a valid backup exists #7753 #8257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkandaswamy
changed the title
mkandaswamy
changed the title
…anges into its own test file: QuickDegradeAndRestoreCommandTopicIntegrationTest
| KsqlRestoreCommandTopic.main( | ||
| new String[]{ | ||
| "--yes", | ||
| "-s", |
There was a problem hiding this comment.
This flag isn't necessary, this flag is for skipping incompatible commands when restoring the command topic
There was a problem hiding this comment.
ah ok, will remove it.
…port in RestoreCommandTopicIntegrationTest
stevenpyzhang
approved these changes
Oct 18, 2021
|
|
||
| // Then | ||
| assertThat(TEST_HARNESS.topicExists(commandTopic), is(false)); | ||
| assertThatEventually("Degraded State", this::isDegradedState, is(true)); |
There was a problem hiding this comment.
Can we switch the order of these two statements? I'm not sure the check for the command topic will happen before the server has fully started up and skipped over any parts that may create a command topic. (I don't think .start() is blocking)
There was a problem hiding this comment.
Done. Swapped the order of two statements.
…e and topic exists in integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7753
During ksql startup, avoid recreating deleted command topic when a valid backup exists.
Earlier, regardless of backup file we used to recreate deleted command topic during ksql startup(which will be out of sync with existing backup). This delays detection of the problem until a new query is issued to ksql server which subsequently will enter DEGRADED status.
With this change, deleted command topics won't be recreated once a valid backup is found and the ksql server will be put on DEGRADED status immediately during the startup process.
Testing done
Unit, integration test and manual verification
Reviewer checklist