fix: Fixes errors and increased latency for pull queries from closing connection #8248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Oct 12, 2021
AlanConfluent
added a commit
that referenced
this pull request
Oct 12, 2021
AlanConfluent
added a commit
to AlanConfluent/ksql
that referenced
this pull request
Oct 13, 2021
… closing connection (confluentinc#8248)" This reverts commit 2a74826.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR #8164 shut down scanning of data by locally and remotely for a pull query once the
PullQueryResultwas stopped. The issue is that closing the connection for a remote request appeared to have introduced failures that were incorrectly retried. Still looking into how this didn't work as intended, but for the moment, rolling back that part of the change.Testing done
Normal tests.
Reviewer checklist