fix: skip adding invalid if not exists to cmd topic #8206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
spena
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Thanks @wcarlson5 . This seems much simpler. Could you add unit tests for this? Also, add some integration tests. Perhaps KsqlResourceTest? Or EndToEndIntegrationTest or a QTT?
...b-rest-app/src/main/java/io/confluent/ksql/rest/server/computation/DistributingExecutor.java
Outdated
Show resolved
Hide resolved
...b-rest-app/src/main/java/io/confluent/ksql/rest/server/computation/DistributingExecutor.java
Outdated
Show resolved
Hide resolved
|
@spena I added a |
|
I just finished running through some manual testing and was able to verify the msg and that the query doesn't vanish on restart |
… skip_if_not_exists_invalid # Conflicts: # ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/computation/DistributingExecutor.java
spena
approved these changes
Sep 30, 2021
wcarlson5
added a commit
that referenced
this pull request
Oct 4, 2021
* fix: skip adding invalid if not exists to cmd topic (cherry picked from commit 540a449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes @spena suggested instead
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist