Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ClassCastException when dropping sources with 2+ insert queries #8205

Merged
merged 1 commit into from
Sep 30, 2021
Merged

fix: ClassCastException when dropping sources with 2+ insert queries #8205

merged 1 commit into from
Sep 30, 2021

Conversation

jzaralim
Copy link
Contributor

Description

Fixes #8129

QueryId does not implement Comparable, so calls made to Stream<QueryId>.sorted() threw errors. This is a quick fix to get around that.

Testing done

Updated unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner September 30, 2021 18:02
@jzaralim jzaralim requested a review from spena September 30, 2021 18:02
@jzaralim jzaralim merged commit a7c6ebe into master Sep 30, 2021
@jzaralim jzaralim deleted the insert branch September 30, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClassCastException when dropping a STREAM with 2+ INSERT INTO statements
2 participants
@jzaralim @spena