feat: Add metrics for stream pull queries over http2 #8168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvcephei
approved these changes
Sep 27, 2021
vpapavas
force-pushed
the
stream-pull-metrics-http2
branch
from
e679702 to
366ec84
Compare
vpapavas
commented
Sep 27, 2021
| @@ -48,13 +58,12 @@ | |||
| import org.junit.Test; | |||
| import org.junit.rules.RuleChain; | |||
| import org.junit.rules.Timeout; | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| @Ignore | |||
There was a problem hiding this comment.
The tests currently don't work on jenkins. There are two issues: 1) The metrics don't get recorded correctly within a single test 2) The metrics get clobbered between tests. There are no functional tests for metrics in the codebase so this seems like a bigger issue than just pull queries hence the tests are disabled for now
There was a problem hiding this comment.
That's a bummer, but I agree it makes sense to just skip it for now. Thanks, @vpapavas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add metrics for stream pull queries over http2
Testing done
Junit test
Reviewer checklist