feat: scalable push query bandwidth throttling #8087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @nateab just signed our Contributor License Agreement. 👍 Always at your service, clabot |
nateab
force-pushed
the
spq_throttling
branch
from
46f9992 to
910a7fa
Compare
ksqldb-rest-app/src/main/java/io/confluent/ksql/api/impl/QueryEndpoint.java
Show resolved
Hide resolved
...est/java/io/confluent/ksql/api/integration/ScalablePushBandwidthThrottleIntegrationTest.java
Outdated
Show resolved
Hide resolved
...est/java/io/confluent/ksql/api/integration/ScalablePushBandwidthThrottleIntegrationTest.java
Show resolved
Hide resolved
...p/src/main/java/io/confluent/ksql/rest/server/resources/streaming/StreamedQueryResource.java
Outdated
Show resolved
Hide resolved
...est-app/src/main/java/io/confluent/ksql/rest/server/resources/streaming/WSQueryEndpoint.java
Show resolved
Hide resolved
nateab
force-pushed
the
spq_throttling
branch
from
6b5f46b to
6377217
Compare
AlanConfluent
approved these changes
Sep 8, 2021
ksqldb-common/src/main/java/io/confluent/ksql/util/KsqlConfig.java
Outdated
Show resolved
Hide resolved
nateab
force-pushed
the
spq_throttling
branch
from
88873aa to
4ca2645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For scalable push queries, once the bandwidth limit is exceeded, do not allow new queries to be created.
Limits the amount of bandwidth used by push queries by using a Sliding Window Log, similar to pull queries. The limit (in MB per hour) can be set using the ksql.query.push.scalable.max.hourly.bandwidth config. Once the limit is hit, scalable push queries will fail immediately.
Testing done
Integration testing added.
Reviewer checklist