fix: add new types to udaf functions #8081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Aug 31, 2021
| return latest(STRUCT_TIMESTAMP, ignoreNulls, getComparator(ignoreNulls)); | ||
| } | ||
|
|
||
| @UdafFactory(description = "return the latest N value of a timestamp column", |
There was a problem hiding this comment.
nit:
Suggested change
| @UdafFactory(description = "return the latest N value of a timestamp column", | |
| @UdafFactory(description = "return the latest N values of a timestamp column", |
and similar for the other descriptions in this file.
| }, | ||
| { | ||
| "name": "collect_list bytes map", | ||
| "format": ["JSON"], |
There was a problem hiding this comment.
Out of curiosity, does the PROTOBUF format not support the BYTES type?
There was a problem hiding this comment.
It does, it just requires specifying the schema to the test, which I was too lazy to do.
added 2 commits
August 31, 2021 12:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for timestamp, time, date and bytes to collect_list, collect_set, latest_by_offset and earliest_by_offset.
Fixes #7787
Testing done
unit/qtt
Reviewer checklist