Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make KsqlAvroSerializerTest work with Java 16 #7873

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

vvcephei
Copy link
Member

Apparently some small things around casting behavior
and error messages have changed. This change makes the
test more generic so that it works regardless of the JVM.

Testing done

Ran the tests on my machine. If they also pass in Jenkins, it should be fine to merge.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vvcephei vvcephei requested a review from a team as a code owner July 25, 2021 03:16
@ghost
Copy link

ghost commented Jul 25, 2021

@confluentinc It looks like @vvcephei just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@vvcephei vvcephei self-assigned this Jul 25, 2021
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for my own education - why are we running this with Jdk16? I'm pretty sure lots of things break at that language level

@vvcephei
Copy link
Member Author

vvcephei commented Aug 9, 2021

Thanks, @agavra . It's not a matter of the compilation language level. I just happen to have the Java 16 runtime on my computer. The exception is fine, but the string that it returns in the exception varies across JVMs. Since the exception message is not in the JVM spec, it seems like we shouldn't write tests that rely on exact phrasing.

Apparently some small things around casting behavior
and error messages have changed. This change makes the
test more generic so that it works regardless of the JVM.
@vvcephei vvcephei force-pushed the fix-ksql-avro-serializer-test branch from 3b5b92d to 01a18d0 Compare August 9, 2021 18:26
@vvcephei vvcephei merged commit bab8874 into master Aug 9, 2021
@vvcephei vvcephei deleted the fix-ksql-avro-serializer-test branch August 9, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants